Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: support for live ISOs to zapper_kvm connector #303

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Conversation

p-gentili
Copy link
Contributor

@p-gentili p-gentili commented Jul 8, 2024

Pending review of the Zapper counterpart.

Description

This PR updates the zapper_kvm connector with support for provisioning a live ISO. Two new arguments make that possible:

  1. boot_from_ext_media: which should be true, so that the USB stick is kept connected to the DUT side
  2. wait_until_ssh: which defaults to true, but it might me useful if the live ISO does not have a SSH server available at boot

Resolved issues

Part of ZAP-840

Documentation

Updated adding a section for the "live ISO" specific parameters

Web service API changes

N/A

Tests

Tested with Zapper by running the corresponding API. An example job using TF would be:

job_queue: 202207-30464
global_timeout: 18000
output_timeout: 1800

provision_data:
  url: https://releases.ubuntu.com/noble/ubuntu-24.04-desktop-amd64.iso
  robot_tasks:
    - hp/pro/sff_400_g9/boot/boot_from_usb.robot
    - common/grub/stop/stop_at_grub.robot
  boot_from_ext_media: true
  wait_until_ssh: false
  skip_download: true  # USB stick already flashed for testing

@p-gentili p-gentili marked this pull request as ready for review July 22, 2024 07:14
@p-gentili p-gentili requested a review from plars July 22, 2024 07:20
Copy link
Contributor

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions.

plars
plars previously approved these changes Jul 30, 2024
Copy link
Contributor

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes you made to the documentation make the "boot_from_ext_media" much more clear. Also, I can see some value in keeping it the same as how it's defined in the zapper source. I think calling it "live_iso" or "live_image" makes it a bit more intuitive, but if you want to keep it the way it is for consistency, I'm fine with that.

Copy link
Contributor

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@plars plars merged commit 0dc2338 into main Jul 31, 2024
5 checks passed
@plars plars deleted the zapper-kvm-live-iso branch July 31, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants