-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: support for live ISOs to zapper_kvm connector #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions.
device-connectors/src/testflinger_device_connectors/devices/zapper_kvm/README.md
Outdated
Show resolved
Hide resolved
device-connectors/src/testflinger_device_connectors/devices/zapper_kvm/README.md
Outdated
Show resolved
Hide resolved
device-connectors/src/testflinger_device_connectors/devices/zapper_kvm/README.md
Show resolved
Hide resolved
device-connectors/src/testflinger_device_connectors/devices/zapper_kvm/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes you made to the documentation make the "boot_from_ext_media" much more clear. Also, I can see some value in keeping it the same as how it's defined in the zapper source. I think calling it "live_iso" or "live_image" makes it a bit more intuitive, but if you want to keep it the way it is for consistency, I'm fine with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Pending review of the Zapper counterpart.Description
This PR updates the zapper_kvm connector with support for provisioning a live ISO. Two new arguments make that possible:
boot_from_ext_media
: which should be true, so that the USB stick is kept connected to the DUT sidewait_until_ssh
: which defaults to true, but it might me useful if the live ISO does not have a SSH server available at bootResolved issues
Part of ZAP-840
Documentation
Updated adding a section for the "live ISO" specific parameters
Web service API changes
N/A
Tests
Tested with Zapper by running the corresponding API. An example job using TF would be: