-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing imx6 recovery install timeout issue #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving Paul to review the code, but as a minimum the documentation should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it definitely needs documentation updates as Jonathan mentioned. However, I'm curious why is this on oemrecovery? I would have guessed this device might use something like muxpi/sdwire/zapper instead? I'm just wondering if we need to support this more generically for other device connectors also, or even if perhaps this wasn't the connector you meant to implement it on.
b33242e
to
b73bd49
Compare
Description: Due to different platform has different install and system boot time, hard coding timeout to 600 is not appropriate, should support assign timeout to device system boot checking. howto: in job.yaml provide provision_data: boot_timeout: <time in second> Resolved issues: Fixing imx6 recovery install timeout issue Documentation: N/A Web service API changes: N/A Tests submit task yaml with boot_timeout and verified boot timeout can be updated Signed-off-by: ChunAn Wu <[email protected]>
Hi Paul |
@kiya956 I talked to @kevinyehk and he confirmed that we have several IoT devices using oemrecovery (which is still very surprising to me! can these not boot from an sd card or usb?) My biggest concern here is that it relies on the test requestor knowing some magic value that is needed for each specific device. The only other options I see are:
|
Hi @plars Thank you for your suggestion, Test requester need to know the recovery time is indeed an issue. |
@kiya956 Option 1 is definitely harder for us and requires a lot more changes and tracking of these special cases in some place like c3. I'd really like to avoid it if we can. Option 2 doesn't necessarily mean that other devices will take longer to provision, just that we might give them a bit more time until we give up trying. But what I'm really curious to know, is - how long do you think the timeout needs to be for these devices? |
@plars It's around 90~100 minutes. |
Description
Resolved issues
Fixing imx6 recovery install timeout issue
Documentation
Web service API changes
Tests