Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hostname field, we don't support this anymore #436

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

kiya956
Copy link
Contributor

@kiya956 kiya956 commented Dec 25, 2024

Description

remove hostname field, we don't support this anymore

Resolved issues

Documentation

Web service API changes

Tests

provision x8high-pdk successfully

@kiya956 kiya956 requested a review from a team as a code owner December 25, 2024 02:20
Copy link
Collaborator

@plars plars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular device connector is an odd one because the docs for it are somewhere else. Otherwise I would ask that the docs be updated as part of this PR. But since that's possible, all I ask is to please make sure that the docs get updated in the appropriate place.

@kiya956
Copy link
Contributor Author

kiya956 commented Dec 31, 2024

This particular device connector is an odd one because the docs for it are somewhere else. Otherwise I would ask that the docs be updated as part of this PR. But since that's possible, all I ask is to please make sure that the docs get updated in the appropriate place.

H

@kiya956 kiya956 closed this Dec 31, 2024
@kiya956
Copy link
Contributor Author

kiya956 commented Dec 31, 2024

This particular device connector is an odd one because the docs for it are somewhere else. Otherwise I would ask that the docs be updated as part of this PR. But since that's possible, all I ask is to please make sure that the docs get updated in the appropriate place.

Hi Paul
Thank you for your time, I know you are on vacation.
I will update the doc in zapper repo. Really appreciate it.

@kiya956 kiya956 reopened this Dec 31, 2024
@p-gentili p-gentili merged commit 53d5268 into canonical:main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants