Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ui support #42

Merged
merged 3 commits into from
May 29, 2024
Merged

feat: add ui support #42

merged 3 commits into from
May 29, 2024

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented May 29, 2024

Description

Add UI support and the associated integration test.

We also take advantage of the opportunity to use ruff and pyright for linting and static analysis in the integration tests Python code.

Note

This is a change we likely want to backport to the 1.15 rock to bring the the release to parity between the k8s and machine charms. I will wait for this PR to be reviewed/merged before creating another one in the release-1.15 branch.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@gruyaume gruyaume marked this pull request as ready for review May 29, 2024 11:31
@gruyaume gruyaume requested a review from a team as a code owner May 29, 2024 11:31
@gruyaume gruyaume merged commit 9e6ec6d into main May 29, 2024
8 checks passed
@gruyaume gruyaume deleted the dev-ui branch May 29, 2024 12:49
gruyaume added a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants