chore: fix order of placeholders for multiple joins (#902)

cap-js · Nov 18, 2024 · e341af4 · e341af4
1 parent c61a04a
commit e341af4
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/db-service/lib/cqn2sql.js b/db-service/lib/cqn2sql.js
@@ -363,10 +363,7 @@ class CQN2SQLRenderer {
       return _aliased(this.quote(this.name(z)))
     }
     if (from.SELECT) return _aliased(`(${this.SELECT(from)})`)
-    if (from.join) {
-      const joinCondition = from.on ? ` ON ${this.where(from.on)}` : '';
-      return `${this.from(from.args[0])} ${from.join} JOIN ${this.from(from.args[1])}${joinCondition}`;
-    }
+    if (from.join) return `${this.from(from.args[0])} ${from.join} JOIN ${this.from(from.args[1])}${from.on ? ` ON ${this.where(from.on)}` : ''}`
   }
 
   /**