Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom index page to the ord-sample #83

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aramovic79
Copy link
Member

No description provided.

@aramovic79
Copy link
Member Author

Bellow is shown how the index page looks like now.
As you can see in the code, the implemented changes have nothing to do with the ORD Plugin, but only with the example application(/xmpl).

image

@swennemers
Copy link
Contributor

Thx @aramovic79 to immediately jump on the issue. I would prefer a solution where the plugin can provide this snippet, I think, I saw some other plugins to contribute to the page once. @RamIndia , can you help with the extension points to hook in for that?

@swennemers
Copy link
Contributor

@aramovic79 & @zongqichen , have a look at https://www.npmjs.com/package/@sap/cds?activeTab=code /@sap/cds/app/index.js, the plugin should return its endpoint as a CAP service (although manually implemented), then it would appear here automatically. @RamIndia suggested to do the same to support the multi tenancy issue #58.

@aramovic79
Copy link
Member Author

aramovic79 commented Nov 4, 2024

@aramovic79 & @zongqichen , have a look at https://www.npmjs.com/package/@sap/cds?activeTab=code /@sap/cds/app/index.js, the plugin should return its endpoint as a CAP service (although manually implemented), then it would appear here automatically. @RamIndia suggested to do the same to support the multi tenancy issue #58.

By looking at the code, it seems to me that the change should be implemented not even in @sap/cds but in @sap/cds-dk. @RamIndia : Am I right?
If so, not sure which change shall be done in the ORD Plugin so that @sap/cds(index.js) "sees" it's endpoint as a CAP service. I think that diving into the code with debugger is not the right approach, we need someone from the CAP team to point us in the right direction.

@aramovic79 aramovic79 marked this pull request as draft November 6, 2024 09:43
@aramovic79 aramovic79 self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ORD links to the CAPs defaults index page, next to the list of APIs and Events
2 participants