Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tasking request creation #48

Merged
merged 15 commits into from
Dec 22, 2023

Conversation

log0s
Copy link
Collaborator

@log0s log0s commented Sep 8, 2023

No description provided.

@log0s log0s changed the base branch from feature/create-tasking-request to main September 8, 2023 16:33
@coveralls
Copy link

coveralls commented Sep 8, 2023

Coverage Status

coverage: 95.806% (+0.2%) from 95.652%
when pulling 9a23b41 on log0s:feature/create-tasking-request
into fbad763 on capellaspace:main.

"windowClose": window_close,
"collectionTier": collection_tier,
"productCategory": product_category,
"archiveHoldback": archive_holdback,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make archiveHoldback, customAttribute1 and customAttribute2 conditional

something like

# above list
CONDITIONAL_PROPERTIES = [..]

# might want to default archive holdback to None
cond_properties = {_snake_to_camel(k): loc[k] for k in CONDITIONAL_PROPERTIES if k in loc and loc[k] is None}

if cond_properties:
    payload["properties"].update(cond_properties)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So archive holdback currently defaults to the string "none"; were you wanting to default to not passing a value at all? I believe that since the others default to None there won't be anything posted if they're not defined by the user.

Copy link
Collaborator

@grmpflh27 grmpflh27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@log0s - looking pretty close.

Only considerable thing that's missing are some examples for the docs (https://capella-console-client.readthedocs.io/en/main/pages/example_usage.html)

-> new sections (1 for create tasking request and 1 for create repeat request) in docs/pages/example_usage.rst would be great

@log0s
Copy link
Collaborator Author

log0s commented Dec 21, 2023

@log0s - looking pretty close.

Only considerable thing that's missing are some examples for the docs (https://capella-console-client.readthedocs.io/en/main/pages/example_usage.html)

-> new sections (1 for create tasking request and 1 for create repeat request) in docs/pages/example_usage.rst would be great

Added some stuff in. Let me know if it looks good or if there's something else you'd like there.

Copy link
Collaborator

@grmpflh27 grmpflh27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks great

@log0s log0s merged commit e891bf7 into capellaspace:main Dec 22, 2023
10 checks passed
@log0s log0s deleted the feature/create-tasking-request branch December 22, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants