Multiple backends refactor #396
Conversation
| if storage_options is not None and "composite_config" in storage_options: | ||
| composite_config = storage_options.get("composite_config", []) | ||
| repositories = [] | ||
| for config in composite_config: | ||
| self.persistence, self.root_dir, self.is_auto_git_enabled = self._load_config( | ||
| config["persistence"], config["root_dir"], is_auto_git_enabled | ||
| ) | ||
| repositories.append(self._get_repository()) | ||
|
|
||
| self.repositories = repositories | ||
| else: | ||
| self.persistence, self.root_dir, self.is_auto_git_enabled = self._load_config( | ||
| persistence, root_dir, is_auto_git_enabled | ||
| ) | ||
| self.repository = self._get_repository() |
There was a problem hiding this comment.
🔥 awesome, this is exactly what I wanted to clean up
rubicon_ml/client/rubicon.py
Outdated
| Config( | ||
| persistence=config["persistence"], | ||
| root_dir=config["root_dir"], | ||
| auto_git_enabled=auto_git_enabled, | ||
| ) |
There was a problem hiding this comment.
this also needs **storage_options
I think we should ultimately just make users pass a list of Configs if they want to use multiple backends - what do you think? we don't need to do it in this PR
There was a problem hiding this comment.
Good catch. Yes I was hoping to split this into two PRs. This one is mostly backwards compatible, and that change would require an API change.
There was a problem hiding this comment.
Also the fact that this didn't cause any unit tests to fail indicates a gap - let me address that before we merge here.
There was a problem hiding this comment.
Yes I was hoping to split this into two PRs. This one is mostly backwards compatible, and that change would require an API change.
perfect, sounds good!
Also the fact that this didn't cause any unit tests to fail indicates a gap - let me address that before we merge here.
thanks!
…alone/rubicon-ml into multiple_backends_refactor
What
Configoptions.How to Test