Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new APIs to Webamp NPM module #1262

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add new APIs to Webamp NPM module #1262

wants to merge 3 commits into from

Conversation

captbaritone
Copy link
Owner

@captbaritone captbaritone commented Aug 25, 2024

TODO

  • Validate APIs work in test environment
  • Add to documentation
  • Figure out how we can cut a release with these new APIs given current state of build

Test Plan

Added the following to the demo site:

const LLAMA_TRACK = {
  metaData: {
    artist: "DJ Mike Llama",
    title: "Llama Whippin' Intro",
  },
  url: llamaAudio,
  duration: 5.322286,
};

webamp.onCurrentTrackDidChange((track, index) => {
  const currentTracks = webamp.getPlaylistTracks();
  const willRunOut =
    index === currentTracks.length - 1 &&
    !webamp.isRepeatEnabled() &&
    !webamp.isShuffleEnabled();
  if (willRunOut) {
    webamp.appendTracks([LLAMA_TRACK]);
  }
});
Screen.Recording.2024-08-25.at.11.37.07.AM.mov

Copy link

github-actions bot commented Aug 25, 2024

Size Change: +315 B (+0.06%)

Total Size: 494 kB

Filename Size Change
./packages/webamp/built/webamp.bundle.min.js 304 kB +170 B (+0.06%)
./packages/webamp/built/webamp.lazy-bundle.min.js 191 kB +145 B (+0.08%)

compressed-size-action

Copy link

netlify bot commented Aug 25, 2024

Deploy Preview for vigorous-lalande-5190c2 failed.

Name Link
🔨 Latest commit bc33e18
🔍 Latest deploy log https://app.netlify.com/sites/vigorous-lalande-5190c2/deploys/66cb7b6a86c5570008e6ea00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant