Try loading preset map from our domain #972
Open
+22
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sentry has lots (~200) of security errors where it looks like this (and other) requests to third party domains fail. For some reason this one appears more frequently than any others so I figured I'd try switching it. I'm not sure why. Maybe some overzealous security plugins have distrusted unpkg? I don't think this is a real fix, but I'm curious to see if it helps.
jberg
approved these changes
Mar 2, 2020
|
|
||
| const presetMap = await import( | ||
| /* webpackChunkName: "milkdrop-presets-weekly" */ | ||
| "butterchurn-presets-weekly/weeks/week1/presets.json" |
There was a problem hiding this comment.
Lets take this change to point to "week" 2 : weeks/week2/presets.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry has lots (~200) of security errors where it looks like this (and
other) requests to third party domains fail. For some reason this one
appears more frequently than any others so I figured I'd try switching
it.
I'm not sure why. Maybe some overzealous security plugins have
distrusted unpkg?
I don't think this is a real fix, but I'm curious to see if it helps.