Skip to content

Commit

Permalink
fix: a11y status for menu button (#4313)
Browse files Browse the repository at this point in the history
* fix: a11y status for menu button

* fix: added json in components json

* fix: formatting

* fix: refactor

---------

Co-authored-by: Alison Joseph <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Nov 20, 2024
1 parent 47634d1 commit 74cc423
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
8 changes: 8 additions & 0 deletions src/data/components.json
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,14 @@
"testing": {
"screenreader": "manual"
}
},
{
"component": "Menu button",
"parentComponent": "Menu buttons",
"overview": false,
"testing": {
"screenreader": "manual"
}
}
]
}
5 changes: 4 additions & 1 deletion src/pages/components/menu-buttons/accessibility.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -208,4 +208,7 @@ custom component.
- When the combo button menu is open, the element (`div`) wrapping the entire
combo button is given `aria-owns` with a value of the menu `id`.

<A11yStatus layout="table" components="Menu buttons" />
<A11yStatus
layout="table"
components={['Menu button', 'Combo button', 'Overflow menu']}
/>
5 changes: 4 additions & 1 deletion src/pages/components/menu-buttons/usage.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ menu with a list of interactive options.
]}
/>

<A11yStatus layout="cards" components="Menu buttons" />
<A11yStatus
layout="cards"
components={['Menu button', 'Combo button', 'Overflow menu']}
/>

## Overview

Expand Down

0 comments on commit 74cc423

Please sign in to comment.