Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu buttons] Accessibility status is missing for Combo button and Overflow menu #4241

Closed
3 tasks done
alina-jacob opened this issue Sep 5, 2024 · 0 comments · Fixed by #4313
Closed
3 tasks done

[Menu buttons] Accessibility status is missing for Combo button and Overflow menu #4241

alina-jacob opened this issue Sep 5, 2024 · 0 comments · Fixed by #4313
Assignees
@riddhybansal
Labels
component: combo-button component: overflow-menu role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 type: docs 📖

Comments

@alina-jacob
Copy link
Member

alina-jacob commented Sep 5, 2024 •
edited
Loading

Problem

The Menu buttons component has three variants, menu button, combo button and overflow menu.
The accessibility tab shows accessibility status for menu button, but doesn't show the status for combo button and overflow menu.

[Note: The component and Github link for accessibility status for Menu button is incorrect, its because both links direct to Menu buttons instead of Menu button (singular / plural) ]
image

Solution

  • Add accessibility status for combo button and overflow menu (check feature flag)
  • Fix component and Github link for Menu button.
  • Add the variants in accessibility status' Usage tab section as well (dropdown ref)
@alina-jacob alina-jacob added this to the 2024 Q3 milestone Sep 5, 2024
@alina-jacob alina-jacob moved this to ⏱ Backlog in Design System Sep 5, 2024
@alina-jacob alina-jacob added severity: 3 https://ibm.biz/carbon-severity and removed status: needs triage 🕵️‍♀️ labels Sep 5, 2024
@riddhybansal riddhybansal self-assigned this Sep 25, 2024
@sstrubberg sstrubberg removed this from the 2024 Q3 milestone Oct 2, 2024
@riddhybansal riddhybansal mentioned this issue Oct 7, 2024
Merged
@riddhybansal riddhybansal moved this from ⏱ Backlog to 🚦 In Review in Design System Oct 7, 2024
@kodiakhq kodiakhq bot closed this as completed in #4313 Nov 20, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riddhybansal riddhybansal

Labels
component: combo-button component: overflow-menu role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: bug 🐛 type: docs 📖
Projects
Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: a11y status for menu button carbon-design-system/carbon-website
3 participants
@sstrubberg @riddhybansal @alina-jacob