fix: a11y status for menu button

[riddhybansal]

Closes #4241

Added Combo button and Overflow menu to a11y tab in menubuttons and fixed github link for menu button

Changelog

New

Added Combo button and Overflow menu to a11y tab in menubuttons and fixed github link for menu button

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
carbondesignsystem	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 5:54pm

[riddhybansal]

Hey there @alisonjoseph the issue for wrong menu button github link is that in storybook its "Menu button" but in carbon website its "Menu buttons" which is making incorrect github url. For now I fixed it with a hack because I was not sure renaming Menu buttons as "Menu button" as it can break other things too in carbon website !! what do you think ?

[alisonjoseph]

I think we could just pull in "Menu button" directly vs. adding custom logic here. Also I think it would be good to add the additional components to the Usage page a11y status cards.

[alisonjoseph]

Suggested change

	components={['Menu buttons', 'Combo button', 'Overflow menu']}
	components={['Menu button', 'Combo button', 'Overflow menu']}

[riddhybansal]

I already did that but there is no component called menu button so its not even getting rendered in the table thats what I was not sure about either I should rename to component in carbon website or I should do that CUSTOM LOGIC , as I think renaming the component might break many things in website.

[alisonjoseph]

Ah I think I know what's missing. This needs to get added to the data/components.json for Menu Button to show up.

{
  "component": "Menu button",
  "parentComponent": "Menu buttons",
  "overview": false,
  "testing": {
    "screenreader": "manual"
  }
},

[alisonjoseph]

Tested locally, LGTM. Not sure why Vercel is refusing to deploy 😞

[alina-jacob]

Looks good, thanks for fixing Riddhi! 🚀