-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the caption #4435
Fixing the caption #4435
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -18,7 +18,7 @@ tabs: ['Usage', 'Style', 'Code', 'Accessibility'] | |||
| Container:focus | border | `$focus` | | |||
|
|||
<Caption> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Caption> | |
<Caption fullWidth> |
Did you also want to add this to all of the Caption components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for not mentioning this earlier in the thread. From what I recall, it has always been broken down this way, so I just wanted to understand the reasoning behind it. I'll confirm with the designers to see if there was any specific reason for this, or if you can help clarify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed with Lauren, we can replace with fullWidth prop.
@Kritvi-bhatia17 could you try to deploy again? It looks like deployment has failed and Preview is not available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Hi @alisonjoseph, I tried redeploying, but the preview link isn’t being generated. Could you please help me with this? |
@Kritvi-bhatia17 just triggered another re-deploy, its just the normal vercel timeout error we get sometimes, the code all looks good. |
The Caption component in the Style tab across several components (e.g., dropdown) is causing spacing issues, resulting in the asterisk appearing as a bullet point instead of footnoting the line above.
Changelog
Changed
Ref: Thread