Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the caption #4435

Merged

Conversation

Kritvi-bhatia17
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 commented Jan 21, 2025

The Caption component in the Style tab across several components (e.g., dropdown) is causing spacing issues, resulting in the asterisk appearing as a bullet point instead of footnoting the line above.

<Caption>
  * Denotes a contextual color token that will change values based on the layer
  it is placed on.
</Caption>

Changelog

Changed

  • Updated the Caption component to prevent the asterisk from being treated as an unordered list by adjusting the code as follows:
<Caption>
  \* Denotes a contextual color token that will change values based on the layer
  it is placed on.
</Caption>

Ref: Thread

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Jan 24, 2025 4:29pm

@Kritvi-bhatia17 Kritvi-bhatia17 marked this pull request as ready for review January 21, 2025 19:05
@Kritvi-bhatia17 Kritvi-bhatia17 requested review from a team as code owners January 21, 2025 19:05
@@ -18,7 +18,7 @@ tabs: ['Usage', 'Style', 'Code', 'Accessibility']
| Container:focus | border | `$focus` |

<Caption>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Caption>
<Caption fullWidth>

Did you also want to add this to all of the Caption components?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not mentioning this earlier in the thread. From what I recall, it has always been broken down this way, so I just wanted to understand the reasoning behind it. I'll confirm with the designers to see if there was any specific reason for this, or if you can help clarify it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed with Lauren, we can replace with fullWidth prop.

@ecarriechung
Copy link

@Kritvi-bhatia17 could you try to deploy again? It looks like deployment has failed and Preview is not available.

Copy link

@ecarriechung ecarriechung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Kritvi-bhatia17
Copy link
Contributor Author

Hi @alisonjoseph, I tried redeploying, but the preview link isn’t being generated. Could you please help me with this?

@alisonjoseph
Copy link
Member

@Kritvi-bhatia17 just triggered another re-deploy, its just the normal vercel timeout error we get sometimes, the code all looks good.

@alisonjoseph alisonjoseph merged commit a137888 into carbon-design-system:main Jan 24, 2025
6 of 7 checks passed
@Kritvi-bhatia17 Kritvi-bhatia17 deleted the caption_update branch January 28, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants