revert influx lib upgrade; Influx smoke test before listening on http port. #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #303 because it is causing the following in our logs: https://fly.io/apps/cargo-quickinstall-stats-server/monitoring
I'm not in the mood to debug it right now, but I think that if the new docker container fails to come up, the old one should stay in the load balancer and prevent an outage (note: this is not the case with the default strategy, but it is with the bluegreen strategy).
With the healthcheck and a bluegreen deployment strategy, we get a nonzero exit code from
flyctl deploy
, and this in its output:This is enough to leave production in a healthy state and give us a build failure notification on the merge-to-main github action.
Unfortunately, it leaves main in a broken state, and requires a maintainer with access to https://fly.io/apps/cargo-quickinstall-stats-server/monitoring to debug the issue.
Ideally, we would also have an integration test that spins up an influxdb 3 server in a docker container and tries to report stats to it. Unfortunately there are no influxdb3 docker images yet. In practice we could probably use an influxdb 2 image, because the stats reporting wire format shouldn't have changed.
Let's just get the stats server back on its feet for now.