Removed redundant modelId

carlosdelest · Dec 11, 2023 · 39e061f · 39e061f
1 parent 4b06655
commit 39e061f
Showing 1 changed file with 2 additions and 19 deletions.
diff --git a/...ck/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/mapper/SemanticTextFieldMapper.java b/...ck/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/mapper/SemanticTextFieldMapper.java
@@ -42,15 +42,8 @@ private static SemanticTextFieldMapper toType(FieldMapper in) {
 
     public static final TypeParser PARSER = new TypeParser((n, c) -> new Builder(n), notInMultiFields(CONTENT_TYPE));
 
-    private final String modelId;
-
-    private SemanticTextFieldMapper(String simpleName, MappedFieldType mappedFieldType, String modelId, CopyTo copyTo) {
+    private SemanticTextFieldMapper(String simpleName, MappedFieldType mappedFieldType, CopyTo copyTo) {
         super(simpleName, mappedFieldType, MultiFields.empty(), copyTo);
-        this.modelId = modelId;
-    }
-
-    public String getModelId() {
-        return modelId;
     }
 
     @Override
@@ -89,24 +82,14 @@ public Builder(String name) {
             super(name);
         }
 
-        public Builder modelId(String modelId) {
-            this.modelId.setValue(modelId);
-            return this;
-        }
-
         @Override
         protected Parameter<?>[] getParameters() {
             return new Parameter<?>[] { modelId, meta };
         }
 
         @Override
         public SemanticTextFieldMapper build(MapperBuilderContext context) {
-            return new SemanticTextFieldMapper(
-                name(),
-                new SemanticTextFieldType(name(), modelId.getValue(), meta.getValue()),
-                modelId.getValue(),
-                copyTo
-            );
+            return new SemanticTextFieldMapper(name(), new SemanticTextFieldType(name(), modelId.getValue(), meta.getValue()), copyTo);
         }
     }