CI: fix condition on which reformats are re-committed #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described at #65 (comment)
If you look through the logs you can see all the git commands that were run in CI. If I emulate those locally I can repro the problem. The old command exit coded 1, even with a clean working tree.
I think what the problem was: actions/checkout uses a fetch-depth of 0, so we only get the most recent commit. So comparing vs HEAD didn't work. But not sure about this. All I know is that this new command works in that test environment, and in my normal dev repo. It's a more common git command too, so that is nice.