Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and authorship info for CITATIONS #16

Conversation

tkphd
Copy link
Contributor

@tkphd tkphd commented May 2, 2024

No description provided.

Copy link

github-actions bot commented May 2, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/hpc-workflows/compare/md-outputs..md-outputs-PR-16

The following changes were observed in the rendered markdown documents:

 01-introduction.md                                | 25 +++++++---
 02-snakemake_on_the_cluster.md                    | 31 ++++++++----
 03-placeholders.md                                | 11 +++--
 04-snakemake_and_mpi.md                           | 57 +++++++++++++++++------
 05-chaining_rules.md                              | 25 +++++++---
 06-expansion.md                                   | 32 ++++++++-----
 CODE_OF_CONDUCT.md                                |  1 -
 config.yaml                                       | 24 +++++-----
 files/snakefiles/cluster_profile_ep02/config.yaml |  3 +-
 files/snakefiles/cluster_profile_ep04/config.yaml |  5 +-
 md5sum.txt                                        | 16 +++----
 11 files changed, 154 insertions(+), 76 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-02 21:19:14 +0000

@tkphd tkphd requested review from ocaisa and reid-a May 2, 2024 21:18
github-actions bot pushed a commit that referenced this pull request May 2, 2024
Copy link
Contributor

@reid-a reid-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@reid-a reid-a merged commit d6be0e2 into carpentries-incubator:main May 2, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 2, 2024
Auto-generated via {sandpaper}
Source  : d6be0e2
Branch  : main
Author  : Andrew Reid <[email protected]>
Time    : 2024-05-02 21:22:16 +0000
Message : Merge pull request #16 from tkphd/ocaisa-issue14-completely-update-the-lesson

Linting and authorship info for CITATIONS
github-actions bot pushed a commit that referenced this pull request May 2, 2024
Auto-generated via {sandpaper}
Source  : da49486
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-02 21:23:21 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : d6be0e2
Branch  : main
Author  : Andrew Reid <[email protected]>
Time    : 2024-05-02 21:22:16 +0000
Message : Merge pull request #16 from tkphd/ocaisa-issue14-completely-update-the-lesson

Linting and authorship info for CITATIONS
github-actions bot pushed a commit that referenced this pull request May 7, 2024
Auto-generated via {sandpaper}
Source  : da49486
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-02 21:23:21 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : d6be0e2
Branch  : main
Author  : Andrew Reid <[email protected]>
Time    : 2024-05-02 21:22:16 +0000
Message : Merge pull request #16 from tkphd/ocaisa-issue14-completely-update-the-lesson

Linting and authorship info for CITATIONS
github-actions bot pushed a commit that referenced this pull request May 14, 2024
Auto-generated via {sandpaper}
Source  : da49486
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-05-02 21:23:21 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : d6be0e2
Branch  : main
Author  : Andrew Reid <[email protected]>
Time    : 2024-05-02 21:22:16 +0000
Message : Merge pull request #16 from tkphd/ocaisa-issue14-completely-update-the-lesson

Linting and authorship info for CITATIONS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants