reader: update fread call improve byte-reader perf #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was motivated by the performance of the original byte-reader
implementation, which was quite slow since it read a file one byte at a
time. Using fread instead, we can net some performance gains.
This currently depends on a signature change to fread in Carp's core
library which isn't at HEAD yet, so that blocks this change. Assuming
that change merges into upstream, we need to also update the
string-reader implementation--this commit handles that as well.