No nested pipe similar to no-nested-subscribe #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is just new rule created based on the no-nested-subscribe, in our code we found this one of big issue when its making code complex and have certain issue as well so we wanted to avoid nested pipe in the code currently there is not other solution available in the next
example in the docs about the growing code face issues with nested pipes for which we require this rule to avoid this complexity
added new test file for no-nested-pipe valid and invalid scenarios
rule usage standalone code for playground
test description update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cartant
In this PR I would like to add new rule: no-nested-pipe
Last year, my team have spent significant effort on improving the maintainability and readability of rxjs statement in the codebase. Avoiding nested pipe has been the most useful rule on driving the better behavior in this area. The team have been enforcing this manually through PR review check last year. I have come cross your library and find it very useful, hence would like to introduce no-nested-pipe rule so that we could all benefit from it.
would you please review this PR and suggest if there is any correction and could please approve this PR if everything is ok