Fix compilation warnings on ioctl-echo-loop and Docker image #26
Conversation
| @@ -102,7 +104,7 @@ static int finish_request(int fd, struct rollup_finish *finish, bool accept) { | |||
| finish->accept_previous_request = accept; | |||
| res = ioctl(fd, IOCTL_ROLLUP_FINISH, (unsigned long) finish); | |||
| if (res != 0) { | |||
| fprintf(stderr, "IOCTL_ROLLUP_FINISH returned error %d\n", res); | |||
| fprintf(stderr, "IOCTL_ROLLUP_FINISH returned error %s [%d]\n", strerror(errno), errno); | |||
There was a problem hiding this comment.
To be very picky, this doesn't work because strerror could modify errno. :/ So you should save it. Elsewhere is the same.
There was a problem hiding this comment.
Right, It may give a strerror errno code instead of what was expected.
|
I guess we need to change the base image of all sunodo templates to debian as well, right? |
mpolitzer
force-pushed
the
chore/deabin-base-image
branch
from
b8e807d to
df34a67
Compare
mpolitzer
changed the title
@tuler We decided to not take this route for now and use this fix instead: https://github.com/cartesi/machine-emulator-tools/pull/26/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R34. rootfs images will still be |
The tools are not building as is.
check: https://discord.com/channels/600597137524391947/1107945240360394853/1177252457894641745
Use a fixed rust version as described on the thread.
There are also some compiler warning fixes on a separate commit.