Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning for not deployed application is presented while loading applications #119

Closed
nevendyulgerov opened this issue Feb 15, 2024 · 0 comments · Fixed by #124
Closed

Warning for not deployed application is presented while loading applications #119

nevendyulgerov opened this issue Feb 15, 2024 · 0 comments · Fixed by #124
Assignees
@nevendyulgerov
Labels
Type: Bug Something isn't working

Comments

@nevendyulgerov
Copy link
Contributor

🙂 Expected behavior

Warning for not deployed application shouldn't appear while loading applications, after a validation error for the applications field is cleared.

🫠 Actual behavior

Warning for not deployed application appears while loading applications, after a validation error for the applications field is cleared.

🧪 Minimal test case

  1. Click Send Transaction
  2. Select ERC20 Deposit
  3. Enter for application 0x674cb14ea404348b3b87c6e629f862014a72b6e9dasdasd to cause a validation error for that field
  4. Enter correct and existing application address like 0x674cb14ea404348b3b87c6e629f862014a72b6e9

🌎 Environment

  • Sepolia network
  • Any rollups version

Video demonstrating the issue:

Screen.Recording.2024-02-15.at.17.45.49.mov
@nevendyulgerov nevendyulgerov added the Type: Bug Something isn't working label Feb 15, 2024
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Feb 15, 2024
@nevendyulgerov nevendyulgerov self-assigned this Feb 21, 2024
@nevendyulgerov nevendyulgerov moved this from 📌 Todo to 🧑‍💻 In Progress in Explorer Unit Feb 21, 2024
@nevendyulgerov nevendyulgerov moved this from 🧑‍💻 In Progress to 👁 In Review in Explorer Unit Feb 27, 2024
@nevendyulgerov nevendyulgerov linked a pull request Feb 27, 2024 that will close this issue
#119 Tweak warning for undeployed application #124
Merged
dandheedge pushed a commit that referenced this issue Apr 1, 2024
@nevendyulgerov
#119 Tweak warning for undeployed application (#124)
010a0ec
@github-project-automation github-project-automation bot moved this from 👁 In Review to 📦 Done in Explorer Unit Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nevendyulgerov nevendyulgerov

Labels
Type: Bug Something isn't working
Projects
Explorer Unit
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#119 Tweak warning for undeployed application cartesi/rollups-explorer
1 participant
@nevendyulgerov