Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#119 Tweak warning for undeployed application #124

Merged

Conversation

nevendyulgerov
Copy link
Contributor

@nevendyulgerov nevendyulgerov commented Feb 27, 2024

I tweaked the behaviour of applications autocomplete field so that the check for undeployed application is evaluated 1 second after the latest batch of applications is pulled. This way the related warning won't appear while the applications query is executed in the background.

To achieve this, I added a custom hook called useUndeployedApplication.

@nevendyulgerov nevendyulgerov added the Type: Bug Something isn't working label Feb 27, 2024
@nevendyulgerov nevendyulgerov self-assigned this Feb 27, 2024
Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 9:15am
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 9:15am
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 9:15am

dandheedge
dandheedge previously approved these changes Mar 8, 2024
@dandheedge
Copy link
Contributor

@nevendyulgerov please rebase your PR with main

@dandheedge dandheedge merged commit 010a0ec into main Apr 1, 2024
8 checks passed
@dandheedge dandheedge deleted the bugfix/119-tweak-warning-for-undeployed-application branch April 1, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Warning for not deployed application is presented while loading applications
2 participants