Feature: Close menu after clicking link #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After refresh a page on dark mode when wallet is already connected the send-transaction button will continue to be disabled due to hydration problems between result comparison between content rendered on server and client.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nevendyulgerov
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Code changes to close the mobile menu when clicking one of the links [
inputs,applications,home] so the user have a feedback that the navigation happen. Also, changes to fix a bug that causes the send-transaction to not be enabled when entering the application with a wallet connected (only in dark-mode gif below). Ps: that also affected the menu for small devices, the send-tx would continue to be disabled even though there is an account connected.Results
Before Fix
After Fix