Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Page Input No Result Display and Query Missing on Refresh #139

Merged
merged 6 commits into from
Mar 25, 2024
Merged

Fix Page Input No Result Display and Query Missing on Refresh #139

merged 6 commits into from
Mar 25, 2024

Conversation

dandheedge
Copy link
Contributor

@dandheedge dandheedge commented Mar 11, 2024 •
edited
Loading

Close #133 #134 #136

@dandheedge dandheedge self-assigned this Mar 11, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 1:17am
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 1:17am
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 1:17am

This was linked to issues Mar 11, 2024
Search query is not propagated on page refresh #134
Closed
Change cursor for color mode switch to pointer #136
Closed
nevendyulgerov
nevendyulgerov reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@nevendyulgerov nevendyulgerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @dandheedge ! We can do a couple of minor tweaks here and there to make some small improvements to the UI.

@dandheedge dandheedge added the Type: Bug Something isn't working label Mar 19, 2024
@nevendyulgerov nevendyulgerov self-requested a review March 21, 2024 14:21
nevendyulgerov
nevendyulgerov approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@nevendyulgerov nevendyulgerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, @dandheedge, thanks for making those tweaks!

@brunomenezes brunomenezes force-pushed the bug/page-inputs-results branch from f8b7626 to a1aa6e5 Compare March 25, 2024 01:12
brunomenezes
brunomenezes approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@brunomenezes brunomenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did a quick rebase before merging.

@brunomenezes brunomenezes merged commit d0347c1 into main Mar 25, 2024
8 checks passed
@brunomenezes brunomenezes deleted the bug/page-inputs-results branch March 25, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunomenezes brunomenezes brunomenezes approved these changes

@nevendyulgerov nevendyulgerov nevendyulgerov approved these changes

Assignees

@dandheedge dandheedge

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@dandheedge @brunomenezes @nevendyulgerov