132. Upgrade Mantine packages #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dandheedge
force-pushed
the
chore/132-bump-mantine-packages-to-latest-version-761
branch
from
0aa068b to
30f898f
Compare
apps/web/package.json
Outdated
| "@mantine/form": "^7.5.0", | ||
| "@mantine/hooks": "^7.5.0", | ||
| "@mantine/notifications": "^7.5.0", | ||
| "@mantine/core": "^7.7.0", |
There was a problem hiding this comment.
Just for info, mantine is now at 7.7.1. Here's the change log. I see that the author(s) fixed some minor issues in that version, so maybe it's worth upgrading to it.
| @@ -119,7 +125,7 @@ describe("VoucherExecution component", () => { | |||
| expect(button.hasAttribute("disabled")).toBe(true); | |||
| }); | |||
|
|
|||
| it("should display enabled button when voucher is not yet executed", () => { | |||
| it("should display enabled button when voucher is not yet executed", async () => { | |||
There was a problem hiding this comment.
Nice, using async and waitFor should take care of the tooltip changes made on the mantine side, namely an async rendering of the tooltip. I don't think we need the timeout configs though, I ran those tests locally without timeouts and they passed ok.
There was a problem hiding this comment.
Looking good, @dandheedge ! I made a couple of small suggestions for you to consider.
dandheedge
force-pushed
the
chore/132-bump-mantine-packages-to-latest-version-761
branch
from
3e8a1ed to
e0de0c7
Compare
brunomenezes
approved these changes
Apr 4, 2024
brunomenezes
deleted the
chore/132-bump-mantine-packages-to-latest-version-761
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #132