Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update conn page to match other pages visual ID #311

Merged
merged 6 commits into from
Jan 23, 2025
Merged

refactor: Update conn page to match other pages visual ID #311

merged 6 commits into from
Jan 23, 2025

Conversation

brunomenezes
Copy link
Collaborator

@brunomenezes brunomenezes commented Jan 22, 2025 •
edited
Loading

Summary

Code changes to make the connections page match the other pages. Also, change the overall presentation to have a similar behaviour to the Specification page (i.e., loading state, when there are no items, etc.). Also update the page.ts for specification to use the PageTitle component. I am including screenshots.

Changes:

  • Update the connection page with a title and use the available PageTitle component.
  • Update the overall presentation of the content of the connection, i.e. call to action to create a connection, fetching state and no items to be displayed to look similar to the Specification page.
  • Update the specification page to also use the PageTitle component rather than a standalone component.
  • Update the PageTitle title to be of order 1 so it outputs an h1 rather than a h2.
  • Update the unit and e2e tests to accommodate the changes in the Connection page.

PS: NextJS auto updated the next-env.d.ts file. But I think that is the second time, probably in a rebase it was overridden by mistake. So it is up again.

Screenshots

Fetching

Old
old-fetching-conns

New
new-fetching-conns

Listing

Old
old-conn-list

New
new-conn-list

No connections to show

Old
old-no-connections

New
new-no-connections

@brunomenezes brunomenezes linked an issue Jan 22, 2025 that may be closed by this pull request
Update Conn page to have visual parity #309
Closed
5 tasks
@vercel Vercel
Copy link

vercel bot commented Jan 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups-explorer-arbitrum-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am
rollups-explorer-arbitrum-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am
rollups-explorer-base-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am
rollups-explorer-base-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am
rollups-explorer-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am
rollups-explorer-optimism-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am
rollups-explorer-optimism-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am
rollups-explorer-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am
rollups-explorer-workshop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:28am

@brunomenezes brunomenezes self-assigned this Jan 22, 2025
@brunomenezes brunomenezes merged commit 4e2f696 into main Jan 23, 2025
23 checks passed
@brunomenezes brunomenezes deleted the feat/309-update-conn-page-to-have-visual-parity branch January 23, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevendyulgerov nevendyulgerov nevendyulgerov approved these changes

@tuler tuler Awaiting requested review from tuler

Assignees

@brunomenezes brunomenezes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Conn page to have visual parity
2 participants
@brunomenezes @nevendyulgerov