Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/server manager #296

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix/server manager #296

merged 2 commits into from
Feb 1, 2024

Conversation

torives
Copy link
Contributor

@torives torives commented Jan 31, 2024

Closes #201
Closes #271

@torives torives self-assigned this Jan 31, 2024
@torives torives force-pushed the fix/server-manager branch from 9a88609 to 5633df4 Compare January 31, 2024 18:28
@torives torives added the no changelog PRs that don't require changes in changelog label Jan 31, 2024
@torives torives force-pushed the fix/server-manager branch from 5633df4 to 189c6a2 Compare January 31, 2024 18:30
Set a fixed timeout for server-manager to finish executing after a call to Cmd.Wait(). For more information, check #201
@torives torives force-pushed the fix/server-manager branch from 189c6a2 to 0840632 Compare January 31, 2024 21:52
@torives torives requested a review from gligneul January 31, 2024 21:53
@torives torives marked this pull request as ready for review January 31, 2024 21:53
Adds a workaround for a problem in server-manager where the cartesi-machine keeps running after server-manager exits. For more information, check #201.
@torives torives force-pushed the fix/server-manager branch from 0840632 to 7458ecb Compare February 1, 2024 09:49
@gligneul gligneul merged commit 5b5dcf5 into main Feb 1, 2024
6 checks passed
@gligneul gligneul deleted the fix/server-manager branch February 1, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs that don't require changes in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SupervisorService times out waiting for services to stop Handle server-manager zombies
2 participants