feat: refactor node config #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoura
force-pushed
the
feature/refactor-node-config
branch
from
a5e4a38 to
ff1a008
Compare
internal/config/generate/helpers.go
Outdated
There was a problem hiding this comment.
Can't we use templates here? I think it would be easier to grasp how the final go code would look like, instead of building it with helper functions like addLine and such.
There was a problem hiding this comment.
I will leave this to a new PR. So we can move forward with other PRs that are on top of PR #318
endersonmaia
requested changes
Feb 23, 2024
fmoura
force-pushed
the
feature/refactor-node-config
branch
from
ff1a008 to
e0f0ae8
Compare
fmoura
force-pushed
the
feature/refactor-node-config
branch
from
e0f0ae8 to
562861a
Compare
fmoura
force-pushed
the
feature/refactor-node-config
branch
from
562861a to
ecf5335
Compare
fmoura
merged commit 058b500
into
feature/imporve-config-code-generation
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.