Disable flaky grpc tests (#1952)

cashapp · Jun 1, 2021 · 7590ed7 · 7590ed7
1 parent 364f226
commit 7590ed7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/misk/src/test/kotlin/misk/client/GrpcClientProviderTest.kt b/misk/src/test/kotlin/misk/client/GrpcClientProviderTest.kt
@@ -32,6 +32,7 @@ import misk.web.jetty.JettyService
 import okhttp3.Response
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.api.Test
 
 @MiskTest(startService = true)
@@ -51,6 +52,7 @@ internal class GrpcClientProviderTest {
     robotLocator = clientInjector.getInstance()
   }
 
+  @Disabled("gRPC tests are flaky, see https://github.com/cashapp/misk/issues/1853")
   @Test
   fun happyPath() {
     assertThat(log).containsExactlyInAnyOrder(

diff --git a/misk/src/test/kotlin/misk/grpc/GrpcConnectivityTest.kt b/misk/src/test/kotlin/misk/grpc/GrpcConnectivityTest.kt
@@ -25,6 +25,7 @@ import okhttp3.RequestBody
 import okio.BufferedSink
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.assertThrows
 import java.io.InterruptedIOException
@@ -56,6 +57,7 @@ class GrpcConnectivityTest {
     client = clientInjector.getInstance(OkHttpClient::class.java)
   }
 
+  @Disabled("gRPC tests are flaky, see https://github.com/cashapp/misk/issues/1853")
   @Test
   fun happyPath() {
     val request = Request.Builder()

diff --git a/misk/src/test/kotlin/misk/web/JsonForProtoEndpointsTest.kt b/misk/src/test/kotlin/misk/web/JsonForProtoEndpointsTest.kt
@@ -25,12 +25,14 @@ import okhttp3.RequestBody.Companion.toRequestBody
 import okio.ByteString
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.api.Test
 import javax.inject.Inject
 
 /**
  * Test that we can send JSON to proto and gRPC endpoints.
  */
+@Disabled("gRPC tests are flaky, see https://github.com/cashapp/misk/issues/1853")
 @MiskTest(startService = true)
 internal class JsonForProtoEndpointsTest {
   @MiskTestModule