Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cdk-database #550

Closed
wants to merge 1 commit into from

Conversation

crodas
Copy link
Contributor

@crodas crodas commented Jan 21, 2025

Description

This is a crate that makes it easier to create a database instance based on an enum that can be constructed from a CLI or an env variable.

This PR has been abstracted from #509, which makit es easier to create binaries that share the same settings / databases as the mintd web-server.


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

This is a crate that makes it easier to create a database instance based on an
enum that can be constructed from a CLI or an env variable.
@crodas crodas force-pushed the feature/cdk-database-instance branch from 359f55e to c40d68b Compare January 21, 2025 06:50
@thesimplekid
Copy link
Collaborator

thesimplekid commented Jan 21, 2025

I don't think this adds much benefit but it does add more overhead for us with an extra crate. Projects that use cdk as a lib will only want one database so they can just import the crate for the one they want to use (sqlite/redb). Where something like mintd where we want to support both can just import both and do his internally.

@crodas
Copy link
Contributor Author

crodas commented Jan 21, 2025

Makes sense, I'll undo this in #509

@crodas crodas closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants