Bump dependencies #575
Open
Bump dependencies #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesimplekid
requested changes
Feb 3, 2025
| @@ -14,7 +14,7 @@ bench = [] | |||
|
|
|||
| [dependencies] | |||
| uuid = { version = "1", features = ["v4", "serde"], optional = true } | |||
| bitcoin = { version = "0.32.2", features = [ | |||
| bitcoin = { version = "0.32.5", features = [ | |||
There was a problem hiding this comment.
cargo will automatically pull in the latest patch version so we do not want to raise this as it should be the minimum version we support. This is true for a few of the ones updated, just going to note it here.
Comment on lines
+63
to
+64
| sync_wrapper = "1" | ||
| bech32 = "0.11" |
There was a problem hiding this comment.
These are not direct deps of ours but transitive dependencies that do not have the minimal version defined correctly so they need to be defined here. So we cant change to a new major or minor version as we want to set the correct major/minor version for the dep.
I haven't run the minimal check in a bit so I should redo it and add to CI and maybe we will be able to update or remove these if your direct dep has been updated. #505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps a few core dependencies to the latest (MSRV-compatible) version.
Checklist
just final-checkbefore committing