-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING.md to casper-network
GitHub Org
#1
base: main
Are you sure you want to change the base?
Add CONTRIBUTING.md to casper-network
GitHub Org
#1
Conversation
Dear @MParlikar , @sacherjj , @ACStoneCL , @ipopescu , |
|
||
Upon successfully submitting the PR, the Casper team will review the PR or reach out accordingly. | ||
|
||
### 4. Creating Pull Requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please match the formatting already discussed and updated here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devendran-m This comment has not been addressed. At the minimum, remove the following heading and incorrect punctuation:
Casper Pull Request Workflow:
Please refer to the Casper Pull Request Workflow below;
profile/CONTRIBUTING.md
Outdated
3. Enhancement Proposals (CEP) | ||
|
||
To propose major changes or enhancements to the Casper Node, we encourage you to submit a Casper Enhancement Proposal (CEP). The CEP process is designed to provide a structured approach to new features, enabling organized discussion and review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these lines be deleted? They seem to be left over from something and already covered below.
3. Enhancement Proposals (CEP) | |
To propose major changes or enhancements to the Casper Node, we encourage you to submit a Casper Enhancement Proposal (CEP). The CEP process is designed to provide a structured approach to new features, enabling organized discussion and review. |
profile/CONTRIBUTING.md
Outdated
|
||
1. **Familiarize Yourself**: Review the [CEP README](https://github.com/casper-network/ceps/blob/main/README.md) to understand the process and what is expected in a CEP. | ||
2. **Draft Your Proposal**: Write a draft of your CEP using the provided [template](https://github.com/casper-network/ceps/blob/main/0000-template.md). | ||
3. **Submit a Pull Request**: Open a PR in the [CEP repository](https://github.com/casper-network/ceps) with your proposal. Ensure you follow all guidelines for submission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. **Submit a Pull Request**: Open a PR in the [CEP repository](https://github.com/casper-network/ceps) with your proposal. Ensure you follow all guidelines for submission. | |
3. **Submit a Pull Request**: Open a PR in the [CEP repository](https://github.com/casper-network/ceps) with your proposal. Please make sure you follow all submission guidelines. |
profile/CONTRIBUTING.md
Outdated
5. **Final Decision**: After discussion, the maintainers will decide whether to accept the CEP. If accepted, it will be merged into the repository and implemented as planned. | ||
|
||
|
||
### 7. Contributing New Projects to Casper Network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### 7. Contributing New Projects to Casper Network | |
### 7. Contributing New Projects to the Casper Ecosystem |
profile/CONTRIBUTING.md
Outdated
|
||
### 7. Contributing New Projects to Casper Network | ||
|
||
This section is specifically created to explain the mandatory requirements that the Community Developers/Teams are required to follow when contributing new projects to the Casper Network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Casper Network is one of the many Casper networks (Mainnet, Testnet, private etc). We need to review the term used here.
This section is specifically created to explain the mandatory requirements that the Community Developers/Teams are required to follow when contributing new projects to the Casper Network. | |
This section is specifically created to explain the mandatory requirements that Community Developers/Teams must follow when contributing new projects to the Casper Ecosystem. |
Hi @ipopescu , |
@devendran-m, many of my comments have not been addressed and are still in an unresolved state. |
Please consider the following when creating a PR:
Provide a useful description of this PR, suitably verbose, aimed at helping reviewers and contributors
Update all relevant changelogs
Changelog:
Provide a link to the GitHub issue relating to this PR
Identify if any downstream impact as in to, SDKs, SmartContracts etc