Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add [storage] section to sidecar config #10

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Do not add [storage] section to sidecar config #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sh/assets/setup_shared.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ function setup_asset_node_configs()
"toml.dump(cfg, open('$PATH_TO_CONFIG_FILE', 'w'));"
)

#TODO[RC]: Remove the line that adds the 'storage' key once the sidecar is updated to not require it for RPC only instances.
if [ -f "$PATH_TO_SIDECAR_TEMPLATE" ]; then
# Prepare the sidecar config file.
cp "$PATH_TO_SIDECAR_TEMPLATE" "$PATH_TO_SIDECAR_CONFIG_FILE"
Expand All @@ -469,7 +468,6 @@ function setup_asset_node_configs()
"cfg['rpc_server']['main_server']['address']='0.0.0.0:$(get_node_port_rpc "$IDX")';"
"cfg['rpc_server']['speculative_exec_server']['address']='0.0.0.0:$(get_node_port_speculative_exec "$IDX")';"
"cfg['rpc_server']['node_client']['address']='0.0.0.0:$(get_node_port_binary "$IDX")';"
"cfg['storage']={'storage_folder': '.'};"
"toml.dump(cfg, open('$PATH_TO_SIDECAR_CONFIG_FILE', 'w'));"
)
fi
Expand Down