Proposition of changes into Casper Types to support a Rust SDK for 1.6 #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacshowa
reviewed
Oct 25, 2023
There was a problem hiding this comment.
Similar to my comments on the related PR against the casper-client, I think it makes sense to approve these to get the SDK out for 1.6. However, I would love to see this feature changed in 2.0 to be additive.
Additionally, I would like to see the lints fixed along with whatever is causing the drone to fail on cargo-test-pr.
…SDK-1.6 # Conflicts: # hashing/Cargo.toml # types/CHANGELOG.md
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Dec 18, 2023
4445: Split 'std' feature into 'std' and 'std-fs-io' in casper-types r=Fraser999 a=Fraser999 This PR restricts the functionality of the `std` feature of `casper-types` to exclude methods unsuitable when compiling the crate to Wasm. It also adds a `std-fs-io` feature to include this functionality. It borrows the concept and supersedes #4348 by `@gRoussac.` casper-ecosystem/rustSDK#8 casper-ecosystem/rustSDK#10 Co-authored-by: Fraser Hutchison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider the following when creating a PR:
This PR intends to pull changes made for the Rust SDK. It is adding a
std-fs-iodefault feature and thus adds several methods or expose them accordingly to be able to compile the SDK into a wasm file.check
casper-ecosystem/rustSDK#8
casper-ecosystem/rustSDK#10
This code is intended to go into 1.6 version for the 1.6 ready version of the SDK.