Introduced VersionFetcher trait to decouple EventListener from http i… #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
force-pushed
the
code_debt_removal_pt_4
branch
from
bcd65f4 to
0a8e5e2
Compare
zajko
commented
Dec 20, 2023
| @@ -0,0 +1,38 @@ | |||
| use casper_event_types::metrics; | |||
There was a problem hiding this comment.
This was moved extracted from lib.rs
…mplementation of version fetching and making unit testing of EventListener possible.
zajko
force-pushed
the
code_debt_removal_pt_4
branch
from
0a8e5e2 to
9a3fede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mplementation of version fetching and making unit testing of EventListener possible. Moving EventListenerStatus and related functionality to a separate file.