Bringing back 1 x filters #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
force-pushed
the
bringing_back_1_x_filters
branch
from
7034382 to
81ea06d
Compare
zajko
force-pushed
the
bringing_back_1_x_filters
branch
5 times, most recently
from
3ef97c6 to
651ff9f
Compare
rafal-ch
reviewed
Apr 25, 2024
| pub(crate) fn new( | ||
| config: Config, | ||
| storage_path: PathBuf, | ||
| enable_legacy_filters: bool, |
There was a problem hiding this comment.
A nit, but I'd rather avoid a bool flag here, as I can imagine that our "standard" filters will become legacy and the legacy ones will become "legacier" :)
How about an enum Filters { V1_x, V2_x } or something along these lines?
Comment on lines
789
to
790
| // `EventFilter::Signatures` should filter out everything except `ApiVersion`s and | ||
| // `FinalitySignature`s. |
There was a problem hiding this comment.
Suggested change
| // `EventFilter::Signatures` should filter out everything except `ApiVersion`s and | |
| // `FinalitySignature`s. | |
| // `EventFilter::Signatures` should filter out everything except `ApiVersion`s, | |
| // `FinalitySignature`s and `Shutdown`s. |
However, I'd consider removing these comments completely because they usually rot and the code is self explanatory.
|
Plase consider adding the new flag to the example configs and perhaps a readme file. |
…r now it provides 2.x SSE events. Applying code review suggestions
zajko
force-pushed
the
bringing_back_1_x_filters
branch
from
e32da8d to
f382467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
As a user of sidecar that's used to consume 1.x style sse events I want to be still able to listen to events after 2.0 changes.
Notes
The goal of this effort is to recreate the sse filter endpoints from 1.x. For now the endpoints will be satureated with 2.x style SSE events, but before release we need to translate them to 1.x format.
Work done
Sidecars SSE server has 3 more endpoints:
/main-> transmitsApiVersion,FinalitySignatureandShutdownevents/deploys-> transmitsApiVersion,TransactionAcceptedandShutdownevents/sigs-> transmitsApiVersion,BlockAdded,TransactionProcessed,TransactionExpired,Fault,StepandShutdownevents