Added documentation for legacy translation. Fixed removed tests. Adde… #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajko
commented
May 8, 2024
| } | ||
|
|
||
| pub fn block_v1_no_deploys_no_era() -> BlockV1 { | ||
| let mut val = serde_json::from_str::<Value>(BLOCK_BODY_V1_ALL_DATA).unwrap(); |
There was a problem hiding this comment.
This is done through json deserialization because BlockBody* structures from casper-types don't offer new functions and/or setters of their fields
There was a problem hiding this comment.
have you tried using TestBlockV1Builder? I think it might simplify this
zajko
commented
May 8, 2024
| @@ -201,7 +209,88 @@ mod tests { | |||
| Some(TransformKindV1::WriteContractPackage), | |||
| maybe_tanslate_stored_value(&stored_value) | |||
| ); | |||
| //TODO wrtite tests for rest of cases | |||
There was a problem hiding this comment.
The structures behind new variants in StoredValue don't have random implementations, and it's not clear how to construct some of these structs. So I gave up having 100% coverage here.
zajko
force-pushed
the
legacy_filters_codefixes_and_testfixes
branch
from
da421e8 to
16aeb1e
Compare
…d more unit tests for the 2.x to 1.x translation process
zajko
force-pushed
the
legacy_filters_codefixes_and_testfixes
branch
from
16aeb1e to
6c76135
Compare
jacek-casper
reviewed
May 9, 2024
types/src/testing.rs
Outdated
Comment on lines
51
to
52
| let escaped = format!("\"{}\"", arg); | ||
| serde_json::from_str(&escaped).unwrap() |
There was a problem hiding this comment.
I think it'd probably be cleaner to use Value here
Suggested change
| let escaped = format!("\"{}\"", arg); | |
| serde_json::from_str(&escaped).unwrap() | |
| serde_json::from_value(serde_json::Value::String(arg)).unwrap() |
jacek-casper
reviewed
May 9, 2024
jacek-casper
reviewed
May 9, 2024
|
left some minor comments... other than that lgtm |
added 7 commits
May 13, 2024 12:36
jacek-casper
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d more unit tests for the 2.x to 1.x translation process