Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-1.5 auction state retrieval #310

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix pre-1.5 auction state retrieval #310

merged 1 commit into from
May 17, 2024

Conversation

jacek-casper
Copy link

Changes the auction endpoint to:

  • always look up the latest contract registry
  • fall back to Key::Hash if we do not find an addressable entity

This fixes NCTL upgrade test 12

rafal-ch
rafal-ch approved these changes May 17, 2024
View reviewed changes
Copy link

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jacek-casper jacek-casper merged commit 2c6bed0 into casper-network:feat-2.0 May 17, 2024
2 checks passed
@jacek-casper jacek-casper deleted the fix-pre-1-5-auction-state branch May 17, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafal-ch rafal-ch rafal-ch approved these changes

@darthsiroftardis darthsiroftardis Awaiting requested review from darthsiroftardis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacek-casper @rafal-ch