Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Sidecar config which allows the whole [storage] section to be … #330

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

zajko
Copy link
Contributor

@zajko zajko commented Jul 2, 2024

…not-present. [storage] can be omitted if sse server is either disabled or not provided.

@zajko zajko force-pushed the making_storage_optional branch from 433ea42 to 4f81659 Compare July 2, 2024 12:06
@zajko zajko requested a review from rafal-ch July 2, 2024 12:06
Copy link

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

…not-present. [storage] can be omitted if sse server is either disabled or not provided.
@zajko zajko force-pushed the making_storage_optional branch from 4f81659 to 2e54500 Compare July 2, 2024 13:59
@zajko zajko merged commit 44ec8ef into casper-network:feat-2.0 Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants