Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose protocol version in status #334

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Expose protocol version in status #334

merged 4 commits into from
Jul 5, 2024

Conversation

jacek-casper
Copy link

No description provided.

rafal-ch
rafal-ch approved these changes Jul 4, 2024
View reviewed changes
Copy link

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

However, I'd like a separate information request to grab just the protocol version to also be added to binary port. Should be a separate ticket/PR though.

@jacek-casper jacek-casper marked this pull request as ready for review July 5, 2024 17:03
@jacek-casper jacek-casper merged commit 3b915c1 into casper-network:feat-2.0 Jul 5, 2024
2 checks passed
@jacek-casper jacek-casper deleted the consume-protocol-status branch July 5, 2024 17:41
@jacek-casper jacek-casper mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafal-ch rafal-ch rafal-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacek-casper @rafal-ch