Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1456 Updating Sending Deploys to Transactions #1484

Merged
merged 3 commits into from
Jul 18, 2024
Merged

1456 Updating Sending Deploys to Transactions #1484

merged 3 commits into from
Jul 18, 2024

Conversation

ACStone-MTS
Copy link
Contributor

What does this PR fix/introduce?

Switching the Sending Deploys doc fully to Sending Transactions with new procedures fully tested on NCTL with Condor-related branches.

Closes #1456

Additional context

Update content of "Sending Transactions" (Formerly Sending Deploys) #1456

Checklist

(Delete any that aren't relevant)

  • Docs are successfully building - yarn install && yarn run build.
  • For new internal links I used relative file paths (with .md extension) - e.g. ../../faq/faq-general.md - instead of introducing absolute file path, or relative/absolute URL.
  • All external links have been verified with yarn run check:externals.
  • My changes follow the Casper docs style guidelines.
  • All technical procedures have been tested (if you want help with this, mention it in Reviewers).

Reviewers

@ipopescu

@ACStone-MTS ACStone-MTS added the v2.0 Merge to feat-2.0_docs label Jul 17, 2024
@ACStone-MTS ACStone-MTS requested a review from ipopescu July 17, 2024 17:25
@ACStone-MTS ACStone-MTS self-assigned this Jul 17, 2024
ipopescu
ipopescu approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@ipopescu ipopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!

source/docs/casper/developers/cli/sending-transactions.md Outdated

```bash
casper-client put-deploy \
casper-client put-txn session\
--node-address <HOST:PORT> \
--chain-name casper-test \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be changed to casper-net-1 to match the result.

source/docs/casper/developers/cli/sending-transactions.md Outdated Show resolved Hide resolved
@ACStone-MTS ACStone-MTS merged commit af8cd43 into casper-network:feat-2.0_docs Jul 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipopescu ipopescu ipopescu approved these changes

Assignees

@ACStone-MTS ACStone-MTS

Labels
v2.0 Merge to feat-2.0_docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ACStone-MTS @ipopescu