Add serde feature #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wspeirs
commented
Sep 5, 2023
wspeirs
commented
- Can serialize and deserialize a Pattern with the feature enabled
- Adds method to create a string from a Pattern
* Can serialize and deserialize a Pattern with the feature enabled * Adds method to create a string from a Pattern
|
I came here to suggest the same! I am currently using Serde support is important for me, because I use glob patterns in my config, and that config can be loaded and saved to a file, using serde. I bet that is something that many clients of glob libraries will want to do. |
hoijui
reviewed
Dec 18, 2023
src/lib.rs
Outdated
|
|
||
| } | ||
|
|
||
| impl<S> Pattern<S> { |
There was a problem hiding this comment.
Could/Should this not rather be impl<S> Display for Pattern<S> {?
There was a problem hiding this comment.
haha! :D
you changed it while I was commenting!
perfect!
|
Catching up on backlog here. Happy to merge this with the changes suggested, looks like I'm able to push them, but will wait just in case OP would like to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.