Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send collected metrics to castai mothership #2

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

Ivaka
Copy link
Contributor

@Ivaka Ivaka commented Mar 12, 2024

No description provided.

@Ivaka Ivaka requested a review from ciprianfocsaneanu March 12, 2024 07:52
@Ivaka Ivaka self-assigned this Mar 12, 2024
@Ivaka Ivaka force-pushed the feat/send-collected-metrics branch from 46bb4e8 to 844a33d Compare March 12, 2024 14:34
@Ivaka Ivaka marked this pull request as ready for review March 12, 2024 14:35
@Ivaka Ivaka force-pushed the feat/send-collected-metrics branch from 844a33d to c6ae28e Compare March 12, 2024 14:39
Copy link
Contributor

@ciprianfocsaneanu ciprianfocsaneanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Only one comment about adding version info in headers

internal/castai/client.go Show resolved Hide resolved
@Ivaka Ivaka merged commit eba64ab into main Mar 13, 2024
2 checks passed
@atanasovskib atanasovskib deleted the feat/send-collected-metrics branch April 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants