Enable docker build and release #3
Conversation
| # push: true | ||
| # tags: ghcr.io/castai/gpu-metrics-exporter/gpu-metrics-exporter:${{ github.sha }} | ||
| - name: Build and push PR | ||
| if: ${{ github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
I might be wrong, since I'm not very familiar with the docker build push action. But will this push an image to the registry on each pull request opened?
There was a problem hiding this comment.
Yes, each pull request would result in an image pushed to registry. This is useful when we do some changes and want to deploy that specific image to a cluster without merging to main.
There was a problem hiding this comment.
I think that this is useful to build at every PR change (as it triggers on each pull_request event) but don't know if we also need to push the image 🤔
There was a problem hiding this comment.
Will PRs opened by people outside of our org also run this, and push it to our registry (how does GitHub handle this for public repos)?
Also maybe we can do it as a manual action instead of running on each PR
There was a problem hiding this comment.
it might me useful in cases when we want to test how changes in PR works on dev/prod (any other cluster) without actually merging this PR
There was a problem hiding this comment.
I think that this is useful to build at every PR change (as it triggers on each pull_request event) but don't know if we also need to push the image 🤔
So should we build and discard it? As Roman mentioned, it is useful to have these images when we want to test before merging
There was a problem hiding this comment.
Will PRs opened by people outside of our org also run this, and push it to our registry (how does GitHub handle this for public repos)?
Also maybe we can do it as a manual action instead of running on each PR
Good point. I think that once the repository is public we'd be able to control whether GHA are ran for PR from forks. At the moment that option is disabled in settings, I am assuming it is because it is not a public repository.
No description provided.