Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment and don't send metrics if no url to scrape #4

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

Ivaka
Copy link
Contributor

@Ivaka Ivaka commented Mar 15, 2024

No description provided.

@Ivaka Ivaka self-assigned this Mar 15, 2024
@Ivaka Ivaka force-pushed the chore/add-deployment branch from f8af4a9 to 04983ef Compare March 18, 2024 21:40
@Ivaka Ivaka force-pushed the chore/add-deployment branch from 04983ef to 596ee6e Compare March 19, 2024 16:08
@Ivaka Ivaka marked this pull request as ready for review March 19, 2024 16:08
@Ivaka Ivaka changed the title Add deployment and don't send metrics if no url to scrape, or no metr… Add deployment and don't send metrics if no url to scrape Mar 19, 2024
Copy link
Contributor

@atanasovskib atanasovskib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 question and 1 possible nit

description: A Helm chart for Kubernetes
type: application
version: 0.1.0
appVersion: "1.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the real version of our app?

internal/exporter/mapper.go Show resolved Hide resolved
@Ivaka Ivaka force-pushed the chore/add-deployment branch from 9545ec9 to 88f6cdc Compare March 22, 2024 06:11
@Ivaka Ivaka merged commit 835f726 into main Mar 22, 2024
2 checks passed
@atanasovskib atanasovskib deleted the chore/add-deployment branch April 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants