Skip to content

Commit

Permalink
Merge pull request #13 from castai/fix/collector/csi-nodes-v1.15
Browse files Browse the repository at this point in the history
fix: handle missing CSINodes list gracefully
  • Loading branch information
zilvinasu authored Apr 7, 2021
2 parents 51c8dfc + f19b5fd commit b4514a6
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions internal/services/collector/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package collector

import (
"context"

"github.com/sirupsen/logrus"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
Expand Down Expand Up @@ -36,10 +37,6 @@ func (c *collector) Collect(ctx context.Context) (*ClusterData, error) {
return nil, err
}

if err := c.collectPods(ctx); err != nil {
return nil, err
}

if err := c.collectPersistentVolumes(ctx); err != nil {
return nil, err
}
Expand Down Expand Up @@ -72,8 +69,11 @@ func (c *collector) Collect(ctx context.Context) (*ClusterData, error) {
return nil, err
}


if err := c.collectCSINodeList(ctx); err != nil {
return nil, err
// https://kubernetes-csi.github.io/docs/csi-node-object.html
// GA since 1.17
c.log.Debugf("could not get CSINodes: %v", err)
}

if err := c.collectStorageClassList(ctx); err != nil {
Expand Down

0 comments on commit b4514a6

Please sign in to comment.