Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Not enough arguments to" false positives on kwarg type checking #725

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

apiology
Copy link
Contributor

This valid code currently reports a false positive during typechecking:

        class Foo
          def bar(baz:, bing:)
          end
        end
        Foo.new.bar(baz: 123, bing: 456)

@apiology apiology marked this pull request as draft October 14, 2024 13:40
@apiology apiology marked this pull request as ready for review October 14, 2024 15:00
@apiology
Copy link
Contributor Author

Just let me know if you'd like any changes or additional tests, @castwide

@apiology
Copy link
Contributor Author

Happy to also send some (smaller) fixes for some other common issues I see with codebases, @castwide?

apiology added a commit to apiology/cookiecutter-ruby that referenced this pull request Oct 26, 2024
@castwide
Copy link
Owner

Thanks, @apiology. The failing tests are mostly unrelated issues that already exist in master and are being resolved in #739, so I'll go ahead and merge this one.

@castwide castwide merged commit 1249f0e into castwide:master Jan 15, 2025
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants