Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sleep menu no longer complains about deafness when using infolink alarm #6026

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chaosvolt
Copy link
Member

Purpose of change (The Why)

Fixes a lil oddity Bardcore spotted in the BN discord.

Describe the solution (The How)

In handle_action.cpp, set the alarm query in sleep() to only remind you you're deaf if you don't have the infolink CBM as an alarm source.

Describe alternatives you've considered

screm

Testing

  1. Compiled and load-tested.
  2. Spawned in as a bionic boffin.
  3. Confirmed that putting earplugs in no longer warns me about being deaf when setting an alarm, due to having infolink CBM.
  4. Added a wrist watch, confirmed that doesn't change the UI so long as I still have an infolink.
  5. Retested as a normal survivor, confirmed I'm warned about deafness if I have earplugs in but not if I can hear.

image

Additional context

Oddly, the alarm option in the wait menu doesn't even bother telling you whether you're deaf or not:
image

This seems to be because the wait() function calls a function called try_set_alarm() that has its own menu panel and neither of those functions check for deafness, while the sleep version is its own whole other thing.

Checklist

Mandatory

@github-actions github-actions bot added the src changes related to source code. label Jan 31, 2025
@chaosvolt chaosvolt enabled auto-merge (squash) February 1, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant