fix: sleep menu no longer complains about deafness when using infolink alarm #6026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Fixes a lil oddity Bardcore spotted in the BN discord.
Describe the solution (The How)
In handle_action.cpp, set the alarm query in
sleep()
to only remind you you're deaf if you don't have the infolink CBM as an alarm source.Describe alternatives you've considered
screm
Testing
Additional context
Oddly, the alarm option in the wait menu doesn't even bother telling you whether you're deaf or not:
![image](https://private-user-images.githubusercontent.com/11582235/408751085-8a614292-97d1-4683-b196-e34a2a8c41f7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMDM0OTEsIm5iZiI6MTczOTEwMzE5MSwicGF0aCI6Ii8xMTU4MjIzNS80MDg3NTEwODUtOGE2MTQyOTItOTdkMS00NjgzLWIxOTYtZTM0YTJhOGM0MWY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDEyMTMxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmODRiOThhOTkwOTVhN2I4YmM2NmU5M2YyNzUzYmQ1YWU2NmIxMTI5NThkNWI4NjIxZTdkZmQ4MzI2NjJlYzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.uwLU4X41izhLbXF5sTfy5vMnUnJFwS5rPGtg5Wlu-uo)
This seems to be because the
wait()
function calls a function calledtry_set_alarm()
that has its own menu panel and neither of those functions check for deafness, while the sleep version is its own whole other thing.Checklist
Mandatory
closes #1234
in Summary of the PR so it can be closed automatically.main
so it won't cause conflict when updatingmain
branch later.