feat(UI): add Simple and Compact compasses for small screens

[Lamandus]

Purpose of change (The Why)

While the old Compass was good and informative, smaller screens (phones, tablets) had their problems of using it.

Describe the solution (The How)

Add the comp. Compass which is just a shorter regular compass. And the simple Compass, which is just one line of where Creatures are in any direction of the player.

Describe alternatives you've considered

Testing

Works as intended, code may be wonky, but that is the best effort I could muster yet.

Additional context

Checklist

Just the Compact version

Simple version

in action

Mandatory

• I wrote the PR title in conventional commit format.
• I ran the code formatter.
• I linked any relevant issues using github keyword syntax like closes #1234 in Summary of the PR so it can be closed automatically.
• I've committed my changes to new branch that isn't main so it won't cause conflict when updating main branch later.

[Lamandus]

the simple version is not too important for me to implement. The compact version is more what I want to keep.

[RoyalFox2140]

[Lamandus]

I used sim.Compass instead of simp.compass due to the problematic word.

[RoyalFox2140]

I used sim.Compass instead of simp.compass due to the problematic word.

Lol, I didn't think about that.

[OrenAudeles]

Using if( adx > 2 * ady ) and so on pins the diagonal wedges to between rotations of rays <2, 1> and <1, 2> which results in the cardinal directions each having around 53 degrees of coverage while the diagonal directions having around 36 degrees of coverage.
Ideally each wedge would get 45 degrees of coverage, which would be using rays along (45deg +- 22.5deg). I wrote a function direction_to_enemy_improved in godbolt online compiler using dot products and ray direction values picked from the continued fraction of cos( 22.5 deg ) / sin( 22.5 deg ).
I think your function direction_to_enemy will probably work well enough, there will just be a small cardinal bias.

[Lamandus]

Using if( adx > 2 * ady ) and so on pins the diagonal wedges to between rotations of rays <2, 1> and <1, 2> which results in the cardinal directions each having around 53 degrees of coverage while the diagonal directions having around 36 degrees of coverage. Ideally each wedge would get 45 degrees of coverage, which would be using rays along (45deg +- 22.5deg). I wrote a function direction_to_enemy_improved in godbolt online compiler using dot products and ray direction values picked from the continued fraction of cos( 22.5 deg ) / sin( 22.5 deg ). I think your function direction_to_enemy will probably work well enough, there will just be a small cardinal bias.

Please be so kind to show me exactly how I have to do it. I am not that code savvy. 😔 Sorry

[OrenAudeles]

Please be so kind to show me exactly how I have to do it. I am not that code savvy. 😔 Sorry

Should be just replacing the contents of direction_to_enemy with what's in direction_to_enemy_improved. oh, and I guess make std::array<wedge_range, 8> wedges; into constexpr std::array<wedge_range, 8> wedges; I kept the function signature the same so it's a drop-in replacement :)

[Lamandus]

works like a charm. Thank you!

[autofix-ci]

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix

1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
2. Continue working.

I do not want the automated commit

1. Format your code locally, then commit it.
2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

[Lamandus]

I don't know why it throws me an error here, AI doesn't help either this time. lol

[OrenAudeles]

Remove the check function entirely. What I suggested was to only replace the contents of your direction_to_enemy function with the contents of direction_to_enemy_improved. All other code was for testing that the output is reasonable.

[Lamandus]

You should have said that... 😆

[OrenAudeles]

yeah looking back I didn't communicate as effectively as I should have what I was suggesting. We got it fixed in the end, though, so the PR process works. "Team work makes the dream work" 😆

[chaosvolt]

Hopefully now it all works, will leave to the others to merge in case some code issue hasn't been addressed that I overlooked.

[Lamandus]

@scarf005 all changes are done and I still need your approval.

After that you don't have to deal with me again probably. The thumb down emojis show me that I am still not welcomed.
I just want to have a easier time on my phone